Adds BSP layer download mirrors#1703
Open
quaresmajose wants to merge 4 commits intoqualcomm-linux:masterfrom
Open
Adds BSP layer download mirrors#1703quaresmajose wants to merge 4 commits intoqualcomm-linux:masterfrom
quaresmajose wants to merge 4 commits intoqualcomm-linux:masterfrom
Conversation
quaresmajose
requested review from
anujm1,
koenkooi,
lumag,
mwasilew,
ndechesne,
ricardosalveti,
sbanerjee-quic and
vkraleti
as code owners
There are situations where we need to know the version of the BSP. For example, to communicate with the exterior of the layer and use the current version. This variable is for that very purpose. Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
quaresmajose
force-pushed
the
mirrors-download
branch
from
4d5fce4 to
49fc763
Compare
ndechesne
reviewed
Mar 6, 2026
This class adds the official mirror of the BSP, which contains the necessary artifacts to minimize reproducibility issues as much as possible. The mirror uses the MIRRORS and thus works in fallback mode; when the official source is not available, the mirror is used. Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
Use the official download mirror by default. Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
ci/mirror-download-disable: Allows to disable the download mirror to avoid potential masking of problems in official sources. ci/mirror-download-test: Was intended to test the download mirror to see if this has everything that is needed without resorting to external sources. Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
quaresmajose
force-pushed
the
mirrors-download
branch
from
49fc763 to
799eab5
Compare
Test run workflowTest jobs for commit 799eab5
All jobs summary
|
Test Results 24 files - 23 24 suites - 185 1h 15m 56s ⏱️ - 2h 14m 39s For more details on these failures, see this check. Results for commit 799eab5. ± Comparison against base commit 8fcbe81. This pull request removes 36 tests. |
| # | ||
|
|
||
| # Add qcom mirror so we can fallback to it | ||
| MIRRORS += "${QCOM_MIRRORS}" |
Contributor
There was a problem hiding this comment.
Can you move this assignment after QCOM_MIRRORS is defined? Easier to parse when reading this.
| " | ||
|
|
||
| # Release | ||
| QCOM_RELEASE = "main" |
Contributor
There was a problem hiding this comment.
QLI_RELEASE or QLI_BASELINE would work better from my perspective.
QCOM is too generic to be used here.
| # Release | ||
| QCOM_RELEASE = "main" | ||
|
|
||
| INHERIT += "qcom-mirrors" |
Contributor
There was a problem hiding this comment.
Can we rename the file to clo-mirrors instead? It is hosted by codelinaro.
lumag
requested changes
Mar 6, 2026
| # Add qcom mirror so we can fallback to it | ||
| MIRRORS += "${QCOM_MIRRORS}" | ||
|
|
||
| QCOM_MIRRORS_URI ?= "https://artifacts.codelinaro.org/aritfactory/qli-ci/downloads/${QCOM_RELEASE}" |
Contributor
There was a problem hiding this comment.
Why do we need a release-specific dir?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the official mirror of the BSP, which contains the necessary artifacts to minimize reproducibility issues as much as possible. The mirror uses the MIRRORS and thus works in fallback mode; when the official source is not available, the mirror is used.